-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: the idx of a pair
inside or
inside pair
is not calculated correctly
#2929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new deploy preview is available on Cloudflare Pages at https://8ac783f0.taquito-test-dapp.pages.dev |
New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/. Published packages:
|
Deploying taquito with
|
Latest commit: |
c49e550
|
Status: | ✅ Deploy successful! |
Preview URL: | https://133be780.taquito.pages.dev |
Branch Preview URL: | https://2927-variant-typing-bug.taquito.pages.dev |
This was referenced Apr 23, 2024
pair
inside or
inside pair
is not calculated correctly
9 tasks
6b03bce
to
ca022fd
Compare
ca022fd
to
307d154
Compare
* feat: option for the user to choose between legacy and updated field numbering * chore: fix typo * chore: add typedoc comments for Token.fieldNumberingStrategy * test: fix failing integration test
…sting all three strategies
307d154
to
c49e550
Compare
dsawali
approved these changes
May 2, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2927
Thank you for your contribution to Taquito.
Before submitting this PR, please make sure:
In this PR, please also make sure:
closes #TICKETNUMBER
in the description box (when applicable)Release Note Draft Snippet
This is a breaking change in (In API behaviour, not the API itself).
Previously, when Michelson Data was converted to javascript objects (For instance, by calling
storage
method of a contract abstraction), in the following scenario we would have an unexpected behaviour:pair
, inside anor
inside anotherpair
pair
's items don't haveannots
.In this case, the the resulting javascript object would look like this
Please note the the inner object's field numbers depend on the object's location in it's parent, and starts with '2' in this example. With this PR, this changes to:
If your dApp code depends on the old behaviour (or changing it requires too much effort, you can call
Tezos.setFieldNumberingStrategy('Legacy')
to keep thew previous behaviour. But please note that in a future release, this option might be removed.