Skip to content

ViteJs #1236

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 16 commits into from
Apr 17, 2021
Merged

ViteJs #1236

merged 16 commits into from
Apr 17, 2021

Conversation

usu
Copy link
Member

@usu usu commented Apr 16, 2021

Revisiting #484 as I had to use again my (slow) notebook for the upcoming Hackathon :-)

Is this something that looks interesting to you?

I guess I could make it workable with another hour or two. At the moment only the Login screen and the home screen works.

Pending:

@usu usu added the WIP Work in progress label Apr 16, 2021
@usu usu marked this pull request as draft April 16, 2021 05:04
@manuelmeister
Copy link
Member

Can Vite only handle files with .vue extension?

@carlobeltrame
Copy link
Member

Nice! Ideally I'd like to use the same build tool for local development and building for production, so there are no unexpected surprises. Can vite also build the finished bundle?
Also, would this work for the client side part of the print service as well? (not a big problem if it does not in my eyes, since it's a separate service)

@usu
Copy link
Member Author

usu commented Apr 16, 2021

Can Vite only handle files with .vue extension?

Vite should be able to handle anything that is Javascript. If I recall correctly, with version 2 Vite not even depends on Vue anymore and is framework agnostic.

What changes is that the file extension cannot be omitted anymore for importing Vue files. This is by design and will stop working in upcoming releases of vue-cli as well.

vitejs/vite#178 (comment)

@usu
Copy link
Member Author

usu commented Apr 16, 2021

Nice! Ideally I'd like to use the same build tool for local development and building for production, so there are no unexpected surprises. Can vite also build the finished bundle?

Yes, vite can also build for production:
https://vitejs.dev/guide/build.html

It uses rollup under the hood for building. Haven't tried it yet, though.

@usu
Copy link
Member Author

usu commented Apr 16, 2021

Also, would this work for the client side part of the print service as well? (not a big problem if it does not in my eyes, since it's a separate service)

Theoretically, yes. Haven't tried it yet & it's still marked as experimental:
https://vite.nuxtjs.org/

@usu usu removed the WIP Work in progress label Apr 17, 2021
@usu usu marked this pull request as ready for review April 17, 2021 11:16
Copy link
Member

@manuelmeister manuelmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

After vite migration the whitespaces of new lines, were not discarded.
@manuelmeister manuelmeister merged commit 0b8204c into ecamp:devel Apr 17, 2021
@usu usu deleted the feature/vite branch November 6, 2022 05:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants