This repository was archived by the owner on Dec 18, 2024. It is now read-only.
Subscribe/Unsubscribe for Python Client #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w invoke subscribe and unsubscribe as well. Signed-off-by: nayakned <naresh.nayak@de.bosch.com>
Signed-off-by: Naresh Nayak <naresh.nayak@de.bosch.com>
| self.subscribeFileDesc[args.Path] = open(fileName, "w") | ||
| self.subscribeIdToPath[resJson["subscriptionId"]] = args.Path | ||
| print("Subscription log available at " + fileName) | ||
| print("Execute tail -f " + fileName + " on another Terminal instance") |
There was a problem hiding this comment.
Is it possible to ASK first, whether to open an xterm? Because often there might not be an X system on the system, and this would fail
There was a problem hiding this comment.
Ofcourse we can add a flag for the user to use (or not use) xterm.
Currently it would fail rather silently.
If you like, we can even redirect the stderr of the subprocess to avoid this.
This way user would not see this at all. The client would use xterm if it is available. Else the user needs to execute the corresponding tail command.
What would be a better solution?
- Checking existence of xterm before starting it in case of a subscribe. - Checks for subscription ID before unsubscribing Signed-off-by: nayakned <naresh.nayak@de.bosch.com>
|
The commit 44ebac0 fixes the issues on subscribing on machines without xterm and also the exceptions thrown when incorrect subscription ids are passed. |
Signed-off-by: nayakned <naresh.nayak@de.bosch.com>
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: nayakned naresh.nayak@de.bosch.com