This repository was archived by the owner on Dec 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 51
Change Subscription Handler to track Channel objects instead of conne… #299
Merged
SebastianSchildt
merged 21 commits into
eclipse-archived:master
from
boschresearch:feature/channel_for_subscription_handler
Jul 20, 2022
Merged
Change Subscription Handler to track Channel objects instead of conne… #299
SebastianSchildt
merged 21 commits into
eclipse-archived:master
from
boschresearch:feature/channel_for_subscription_handler
Jul 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…id VSS datapoints. Signed-off-by: nayakned <naresh.nayak@de.bosch.com>
…ctionID Signed-off-by: Sebastian Schildt <sebastian.schildt@de.bosch.com>
…ng kuksaChannel. Signed-off-by: nayakned <naresh.nayak@de.bosch.com>
Signed-off-by: Sebastian Schildt <sebastian.schildt@de.bosch.com>
Signed-off-by: nayakned <naresh.nayak@de.bosch.com>
Signed-off-by: nayakned <naresh.nayak@de.bosch.com>
Signed-off-by: Sebastian Schildt <sebastian.schildt@de.bosch.com>
Signed-off-by: Sebastian Schildt <sebastian.schildt@de.bosch.com>
…toring Signed-off-by: Sebastian Schildt <sebastian.schildt@de.bosch.com>
…essing commands Signed-off-by: Sebastian Schildt <sebastian.schildt@de.bosch.com>
Signed-off-by: Sebastian Schildt <sebastian.schildt@de.bosch.com>
Signed-off-by: Sebastian Schildt <sebastian.schildt@de.bosch.com>
Signed-off-by: Sebastian Schildt <sebastian.schildt@de.bosch.com>
Signed-off-by: Sebastian Schildt <sebastian.schildt@de.bosch.com>
Unittest workable again, so basically contains the whole grpc subscription code now, just missing clients @nayakned (still can't you add as reviewer here. We should check what is the issue here) |
…ature/channel_for_subscription_handler
Signed-off-by: nayakned <naresh.nayak@de.bosch.com>
…:boschresearch/kuksa.val into feature/channel_for_subscription_handler
Signed-off-by: Sebastian Schildt <sebastian.schildt@de.bosch.com>
Signed-off-by: Sebastian Schildt <sebastian.schildt@de.bosch.com>
Signed-off-by: Sebastian Schildt <sebastian.schildt@de.bosch.com>
Signed-off-by: nayakned <naresh.nayak@de.bosch.com>
Tested parallel subscriptions with websockets and gRPC. Looks good. |
nayakned
approved these changes
Jul 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and found good enough to be merged.
This was referenced Jul 20, 2022
This was referenced Jul 21, 2022
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ctionID
Signed-off-by: Sebastian Schildt sebastian.schildt@de.bosch.com