This repository was archived by the owner on Dec 18, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move metadata fields to
.metadata
inDatapoint
.This makes it more clear what
VIEW_METADATA
refers to and it makes it possible to haveFIELD_METADATA
.Add
fields
in addition toview
inGet
&Subscribe
This makes it possible to subscribe to single fields. It's not really needed for
Get
but it seems consistent to add it to both.Because of this I also removed for example
VIEW_UNIT
since it's now equally easy to addFIELD_METADATA_UNIT
tofields
. In general I thinkview
is a good solution to having a default view and a convenient way to request multiple fields. But perhaps not for specifying individual fields.Include which fields have changed in subscription replies.
In order for a client to tell which field has changed (e.g. if it subscribes to both
value
andactuator_target
).Various cleanup
Status
Not included
VehiclePropertyStatus
for everyVehiclePropertyValue
which can beAVAILABLE
NOT AVAILABLE
orERROR
. And databroker which has the same concept embedded in theoneof value
. The point is that a missing value isn't even necessarily an error and it should still be possible to at leastGet
andSubscribe
to such aDatapoint
.