*: Rename kuksa-viss-client kuksa-client #379
Conversation
romainletendart
force-pushed
the
romainletendart/rename-kuksa-client
branch
2 times, most recently
from
7c78a3a to
7a6d78c
Compare
| :oo. oho -+: -hh/ | ||
| .+o+-`oho `:shy- | ||
| ./o/ohy//+oyhho- | ||
| `-/+oo+/:. | ||
|
|
||
| Default tokens directory: /home/erik/.local/lib/python3.9/site-packages/kuksa_certificates/jwt |
There was a problem hiding this comment.
Not an issue of this PR, but we might want to change this later
There was a problem hiding this comment.
I would keep that for later then.
| @@ -1,22 +1,22 @@ | |||
| {"version": 2, "width": 80, "height": 33, "ts": 1599119755, "env": {"SHELL": "/usr/bin/fish", "TERM": "rxvt-unicode-256color"}} | |||
| [0.028694, "o", "\u001b]0;fish /home/wenwen/tools/kuksa.val"] | |||
There was a problem hiding this comment.
If we change these can we at least also re-render them? See https://github.com/eclipse/kuksa.val/blob/master/doc/pictures/README.md
(shall we also redo them (e.g. record fresh .casts) maybe, but if not super easy maybe not in this PR)
There was a problem hiding this comment.
I re-rendered the GIFs.
Let's keep re-recording for later I would say.
There was a problem hiding this comment.
I tired the built docker and it still worked (the VISS part at least). Changes look good, I do think at the very least we should generate updated gifs from the modified .cast fiels (see comment above). Otherwise I'd rather merge this fast and "fail forward", because this PR touches a lot of files, and keeping it open too long will make things painful...
Package directory and name shall use a dash as per https://pep8.org/#package-and-module-names. Entry point shall also use a dash as it is common for UNIX programs. The imported python package has to use an underscore however otherwise we cannot import it (SyntaxError). Fixes eclipse-archived#318. Signed-off-by: Romain Létendart <romain.letendart@fr.bosch.com>
romainletendart
force-pushed
the
romainletendart/rename-kuksa-client
branch
from
7a6d78c to
11cb0cd
Compare
Package directory and name shall use a dash as per https://pep8.org/#package-and-module-names.
Entry point shall also use a dash as it is common for UNIX programs. The imported python package has to use an underscore however otherwise we cannot import it (SyntaxError).
Fixes #318.