This repository was archived by the owner on Dec 18, 2024. It is now read-only.
Update VSS parser #456
Merged
Update VSS parser #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argerus
force-pushed
the
feature/update_vss_parser
branch
from
9bea051 to
649c37e
Compare
erikbosch
reviewed
Jan 20, 2023
| }) | ||
| .map_err(|err| err.into()), | ||
| types::DataType::Int32Array => serde_json::from_value::<Vec<i32>>(value) | ||
| .map(|value| Some(types::DataValue::Int32Array(value))) |
There was a problem hiding this comment.
How come it says | value| here and on line 314? Error or something i do not understand? I.e. when shall | array| be used and when shall | value| be used?
There was a problem hiding this comment.
That was pretty eagle-eyed of you :)
It's not an error, since it's only describes what to name the input variable in the closure for the map function.
It is inconsistent, though, so I'll change it.
Add support for parsing `min`, `max` & `allowed`.
argerus
force-pushed
the
feature/update_vss_parser
branch
from
649c37e to
212e522
Compare
SebastianSchildt
approved these changes
Jan 23, 2023
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for parsing
min,max&allowed.