This repository was archived by the owner on Dec 18, 2024. It is now read-only.
Add TLS support #518
Merged
Add TLS support #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argerus
force-pushed
the
topic/add_tls_databroker
branch
3 times, most recently
from
c8c9040 to
2a5d91c
Compare
int0x27
suggested changes
Apr 4, 2023
argerus
force-pushed
the
topic/add_tls_databroker
branch
from
2a5d91c to
c04dfd4
Compare
sophokles73
reviewed
Apr 14, 2023
| @@ -247,14 +247,15 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> { | |||
| .value_name("PORT") | |||
| .required(false) | |||
| .env("KUKSA_DATA_BROKER_PORT") | |||
| .value_parser(clap::value_parser!(u16).range(1..)) | |||
| .value_parser(clap::value_parser!(u16)) | |||
There was a problem hiding this comment.
my understanding is that the port number 0 can be used to bind to any free port? If so, then I think this is worth mentioning in the property's description both in the source code as well as in the README
There was a problem hiding this comment.
Yes, that is correct (and the reason I removed the limit of > 0).
With that said, it doesn't really do much good at the moment as databroker isn't printing which port it binds to (when using port 0) as it's just printing the port provided verbatim..
I have a plan to fix it, but as it's a bit involved I didn't do it as part of this PR.
Regarding documenting this behaviour, I mean sure it doesn't hurt, but it's standard unix behaviour, right?
SebastianSchildt
approved these changes
Apr 17, 2023
Closed
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic functionality is there, but more work is needed in terms of documentation, ease of use.