This repository was archived by the owner on Dec 18, 2024. It is now read-only.
Update threaded API doc #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasmittag
reviewed
Jun 19, 2023
| @@ -33,7 +33,7 @@ If you wish to connect to a gRPC server e.g. `kuksa-databroker`, you should inst | |||
| ```console | |||
| $ kuksa-client --ip 127.0.0.1 --port 55555 --protocol grpc --insecure | |||
| ``` | |||
| Note: `--insecure` is required because `kuksa-databroker` does not yet support encryption or authentication. | |||
| Note: `--insecure` is required because `kuksa-databroker` does not yet support TLS encryption or authentication. | |||
There was a problem hiding this comment.
this isn't true anymore or am I wrong. Databroker supports TLS but the client not at this time?
There was a problem hiding this comment.
Correct, or at least not with the current default certificates. I am touching this file in https://github.com/eclipse/kuksa.val/pull/580/files#diff-9e56616746625998b6fde6fba9bd42bf7385758ccb26a51ef83462310f06123c as well, but it could better be rephrased here
lukasmittag
approved these changes
Jun 19, 2023
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #524