Skip to content
This repository was archived by the owner on Dec 18, 2024. It is now read-only.

Make insecure default for Databroker #588

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

erikbosch
Copy link
Contributor

Reverts previous change.
Short term decision is that we will not change default behavior, KUKSA.val Databroker shall unless indicated by arguments start in insecure mode, i.e.e. accepting non-TLS connections (only).

We agreed that this MAY change in the future, so a warning shall be given.

Example log below showing outcome if not specifying --insecure

erik@debian3:~/kuksa.val/kuksa_databroker$ cargo run --bin databroker
   Compiling databroker v0.3.1 (/home/erik/kuksa.val/kuksa_databroker/databroker)
    Finished dev [unoptimized + debuginfo] target(s) in 7.01s
     Running `/home/erik/kuksa.val/target/debug/databroker`
2023-06-29T09:25:32.425683Z  INFO databroker: Init logging from RUST_LOG (environment variable not found)
2023-06-29T09:25:32.425744Z  INFO databroker: Starting Kuksa Databroker d0b6052412936b3aee3ded5f533079c20ae568ea
2023-06-29T09:25:32.425847Z  WARN databroker: Default behavior may change in the future, please use --insecure if you want an insecure connection!
2023-06-29T09:25:32.425876Z  INFO databroker::broker: Starting housekeeping task
2023-06-29T09:25:32.425967Z  WARN databroker::grpc::server: TLS is not enabled
2023-06-29T09:25:32.425982Z  WARN databroker::grpc::server: Authorization is not enabled
2023-06-29T09:25:32.426154Z  INFO databroker::grpc::server: Listening on 127.0.0.1:55555
^C2023-06-29T09:25:35.402565Z  INFO databroker: received SIGINT
2023-06-29T09:25:35.402629Z  INFO databroker::grpc::server: Shutting down

Reverts previous change.
Short term decision is that we will not change default behavior,
KUKSA.val Databroker shall unless indicated by arguments start
in insecure mode, i.e.e. accepting non-TLS connections (only).

We agreed that this MAY change in the future, so a warning shall be given.
@erikbosch erikbosch marked this pull request as ready for review June 29, 2023 14:49
@argerus argerus merged commit d4e2720 into eclipse-archived:master Jun 29, 2023
@erikbosch erikbosch deleted the erik_insecure branch September 29, 2023 09:29
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants