Skip to content
This repository was archived by the owner on Dec 18, 2024. It is now read-only.

Add discoverability feature to kuksa.val.v1 API #641

Conversation

rafaeling
Copy link
Contributor

PR that implements the following examples table for discoverability feature.

@argerus argerus changed the title Add discoverability feature to DataBroker Add discoverability feature to kuksa.val.v1 API Aug 23, 2023
@rafaeling rafaeling force-pushed the feature/add_discoverability_to_databroker branch from 91bcc29 to c56e934 Compare August 23, 2023 13:33
@argerus argerus force-pushed the feature/add_discoverability_to_databroker branch from f5cdeea to d7499a5 Compare September 5, 2023 08:08
Comment on lines 170 to 172
Err(_error) => {
println!("Error: Invalid Regex");
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Return error to client?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, should not return anything

Copy link
Contributor

@argerus argerus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't actually tested it, but it looks good to me now.

@argerus argerus merged commit 9b7861d into eclipse-archived:master Sep 5, 2023
@erikbosch erikbosch deleted the feature/add_discoverability_to_databroker branch October 31, 2024 13:12
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants