Skip to content
This repository was archived by the owner on Dec 18, 2024. It is now read-only.

Use shared SPDX action #643

Merged

Conversation

SebastianSchildt
Copy link
Contributor

This iuses the shared SPDX action in the new Orga. Should not change anyhting functionality wise.

I am however not sure if deleting the action itself has neagative side effects in case it is used elsewhere. If other repos refer to a tag, no issue, if they refer to no reference or master it needs further PRs in the other Repos. Any idea @erikbosch ?

Signed-off-by: Sebastian Schildt <sebastian.schildt@de.bosch.com>
@erikbosch
Copy link
Contributor

Don't you need to change https://github.com/eclipse/kuksa.val/blob/master/.github/workflows/check_license.yaml so that it uses the action from the new location (i.e. https://github.com/eclipse-kuksa/kuksa-actions)

Yes, it is true that other workflows in other repos might need to be changed (like https://github.com/eclipse/kuksa.val.feeders/blob/main/.github/workflows/check_license.yaml) but that is wanted. Using latest master/main is always risky :-)

@SebastianSchildt
Copy link
Contributor Author

Don't you need to change https://github.com/eclipse/kuksa.val/blob/master/.github/workflows/check_license.yaml so that it uses the action from the new location (i.e. https://github.com/eclipse-kuksa/kuksa-actions)

I need, I did, I didn't push, hopefully fixed now

Signed-off-by: Sebastian Schildt <sebastian.schildt@de.bosch.com>
@@ -21,8 +21,8 @@ jobs:
- name: Set license
run: |
echo "licenses=Apache-2.0" >> $GITHUB_ENV

- uses: ./.github/actions/spdx

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to remove trailing whitespaces on line 10 as well

@SebastianSchildt SebastianSchildt force-pushed the feature/shared_spdx_action branch from 8e4bb42 to a45ca10 Compare September 5, 2023 08:46
@erikbosch erikbosch merged commit 92cc002 into eclipse-archived:master Sep 5, 2023
@SebastianSchildt SebastianSchildt deleted the feature/shared_spdx_action branch February 29, 2024 05:16
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants