Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Apply themed horizontal gridline color in timeline-chart when switching themes #480

Open
bhufmann opened this issue Sep 15, 2021 · 4 comments
Labels
bug Something isn't working Theia UI frontend timeline-chart Involves changes in the timeline chart project: https://github.com/theia-ide/timeline-chart

Comments

@bhufmann
Copy link
Collaborator

#442 changed the color for horizontal and vertical gridline colors and they are not the same anymore. When switching the theme from dark to light (or vice versa) then the horizontal gridline color is not updated until either new TimeGraphRows are created or the view is closed and opened again. The reason is that the TimeGraphRow objects are created once and the row style is created using the rowStyleProvider instantiated in the TimegraphOutputComponent.

This issue is track the changes needed in the theia-trace-extension and timeline-chart to allow switch the horizontal line colors dynamically at theme change.

@bhufmann bhufmann added bug Something isn't working timeline-chart Involves changes in the timeline chart project: https://github.com/theia-ide/timeline-chart Theia UI frontend labels Sep 15, 2021
@bhufmann bhufmann changed the title Aplly themed horizontal gridline color in timeline-chart when switching themes Apply themed horizontal gridline color in timeline-chart when switching themes Sep 15, 2021
@ebugden
Copy link
Contributor

ebugden commented Sep 15, 2021

Since this issue has to do with legibility and consistent theming of charts, I would argue it fits into the "Read and navigate a chart" project. I'll give the project a detailed description to clarify. (The "Open relevant views" project has to do with which analyses are available and whether they provide analytical value with the data in the trace.)

(Same comment for #481)

Thank you for taking extra the time to sort new issues into projects! Let me know if any projects have titles or descriptions that aren't clear.

@bhufmann
Copy link
Collaborator Author

Since this issue has to do with legibility and consistent theming of charts, I would argue it fits into the "Read and navigate a chart" project. I'll give the project a detailed description to clarify. (The "Open relevant views" project has to do with which analyses are available and whether they provide analytical value with the data in the trace.)

(Same comment for #481)

Thank you for taking extra the time to sort new issues into projects! Let me know if any projects have titles or descriptions that aren't clear.

@ebugden thanks for the clarification. Yes, I'm a bit lost which project to assign new issue. I just looked at other trackers in the project to decide where to put. Please provide some clarification the project.

@ebugden
Copy link
Contributor

ebugden commented Sep 15, 2021

Added description to "Navigate and read a chart": "Navigation features and core chart elements (ex. axes, labels, gridlines) that make it possible for a user to read and explore chart data." How does that sound?

(Now that people may start using Github projects more, maybe we should do a general review of whether they are set up well?)

Can I swap the project assignment to "Navigate and read a chart"?

@bhufmann
Copy link
Collaborator Author

Added description to "Navigate and read a chart": "Navigation features and core chart elements (ex. axes, labels, gridlines) that make it possible for a user to read and explore chart data." How does that sound?

Sounds better.

(Now that people may start using Github projects more, maybe we should do a general review of whether they are set up well?)

Can I swap the project assignment to "Navigate and read a chart"?

Yes, you can change it.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working Theia UI frontend timeline-chart Involves changes in the timeline chart project: https://github.com/theia-ide/timeline-chart
Projects
None yet
Development

No branches or pull requests

2 participants