Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Allow different colors definition for timegraph outputs. #481

Open
bhufmann opened this issue Sep 15, 2021 · 0 comments
Open

Allow different colors definition for timegraph outputs. #481

bhufmann opened this issue Sep 15, 2021 · 0 comments
Labels
enhancement New feature or request Theia UI frontend timeline-chart Involves changes in the timeline chart project: https://github.com/theia-ide/timeline-chart

Comments

@bhufmann
Copy link
Collaborator

Before #442 the horizontal, vertical gridline and text color used where the same. Only one style lineColor is defined in the OutputComponentStyle. This lineColor is propagated to the TimeGraphComponent and TimeAxisComponent. Having different style properties in OutputComponentStyle allow to be more selective when configuring the colors.

Please note #442 hard-coded the horizontal and vertical gridline color in TimeGraphComponent and with the implementation of this tracker, the hard-coded values can be removed and the new color properties can be used.
@bhufmann bhufmann added enhancement New feature or request timeline-chart Involves changes in the timeline chart project: https://github.com/theia-ide/timeline-chart Theia UI frontend labels Sep 15, 2021
@ebugden ebugden mentioned this issue Sep 15, 2021
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement New feature or request Theia UI frontend timeline-chart Involves changes in the timeline chart project: https://github.com/theia-ide/timeline-chart
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bhufmann