Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Change the default jwtproxy image to the latest one. #16128

Merged
merged 4 commits into from
Mar 2, 2020
Merged

Change the default jwtproxy image to the latest one. #16128

merged 4 commits into from
Mar 2, 2020

Conversation

metlos
Copy link
Contributor

@metlos metlos commented Feb 25, 2020

What does this PR do?

Changes the default jwtproxy image to the latest released.

This is only a temporary solution that we put in place to have something working before we employ a more complete solution that will be part of the re-opened #15651.

What issues does this PR fix or reference?

#16112

@metlos
Change the default jwtproxy image to the latest one.
2ad6265 
Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. labels Feb 25, 2020
@che-bot
Copy link
Contributor

che-bot commented Feb 25, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@nickboldt nickboldt mentioned this pull request Feb 26, 2020
Closed
24 tasks
@metlos
Another image was created. We need to use this one.
f3e087e 
Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Feb 26, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@che-bot
Copy link
Contributor

che-bot commented Feb 26, 2020 •
edited by dmytro-ndp
Loading

E2E tests of Eclipse Che Multiuser on OCP has failed:

Use command [ci-test] to rerun the test.

@Ohrimenko1988
Copy link
Contributor

[ci-test]

@che-bot
Copy link
Contributor

che-bot commented Feb 26, 2020

E2E tests of Eclipse Che Multiuser on OCP has failed:

Use command [ci-test] to rerun the test.

@metlos
Merge remote-tracking branch 'upstream/master' into new-jwtproxy-image
ea3f737 
Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Feb 26, 2020

E2E tests of Eclipse Che Multiuser on OCP has failed:

Use command [ci-test] to rerun the test.

@che-bot
Copy link
Contributor

che-bot commented Feb 26, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@skabashnyuk
Copy link
Contributor

[ci-test]

@skabashnyuk
Copy link
Contributor

[ci-build]

@che-bot
Copy link
Contributor

che-bot commented Feb 27, 2020

E2E tests of Eclipse Che Multiuser on OCP has failed:

Use command [ci-test] to rerun the test.

@skabashnyuk
Copy link
Contributor

[ci-test]

@che-bot
Copy link
Contributor

che-bot commented Feb 27, 2020

E2E tests of Eclipse Che Multiuser on OCP has failed:

Use command [ci-test] to rerun the test.

@metlos
Merge remote-tracking branch 'upstream/master' into new-jwtproxy-image
be26ae3 
Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Mar 2, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@ibuziuk
Copy link
Member

ibuziuk commented Mar 2, 2020

@metlos do you plan to apply the same fix to 7.9.x?

@che-bot
Copy link
Contributor

che-bot commented Mar 2, 2020

E2E tests of Eclipse Che Multiuser on OCP has failed:

Use command [ci-test] to rerun the test.

@metlos
Copy link
Contributor Author

metlos commented Mar 2, 2020

I do, we're just waiting for a successful CI pass..

@metlos
Copy link
Contributor Author

metlos commented Mar 2, 2020

ci-test

@metlos
Copy link
Contributor Author

metlos commented Mar 2, 2020

[ci-test]

@SkorikSergey
Copy link
Contributor

[ci-build]

@che-bot
Copy link
Contributor

che-bot commented Mar 2, 2020

E2E tests of Eclipse Che Multiuser on OCP has been successful:

@metlos metlos merged commit 5d80e1c into eclipse-che:master Mar 2, 2020
@che-bot che-bot added this to the 7.10.0 milestone Mar 2, 2020
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Mar 2, 2020
@metlos metlos deleted the new-jwtproxy-image branch March 2, 2020 17:09
metlos added a commit that referenced this pull request Mar 3, 2020
@metlos
Change the default jwtproxy image to the latest one. (#16128)
ca23159 
Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
@metlos metlos mentioned this pull request Mar 3, 2020
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ibuziuk ibuziuk ibuziuk approved these changes

@l0rd l0rd Awaiting requested review from l0rd

@nickboldt nickboldt Awaiting requested review from nickboldt

@rhopp rhopp Awaiting requested review from rhopp

@sleshchenko sleshchenko Awaiting requested review from sleshchenko

Assignees
No one assigned
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Milestone
7.10
Development

Successfully merging this pull request may close these issues.
6 participants
@metlos @che-bot @Ohrimenko1988 @skabashnyuk @ibuziuk @SkorikSergey