Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

#1931: fix that not all placeholders were supported in connection target filtering #1932

Conversation

thjaeckle
Copy link
Member

@thjaeckle thjaeckle commented Apr 29, 2024

Added support for placeholders in Connection "targets":

  • feature:id
  • entity:id
  • entity:namespace
  • entity:name
  • thing:id
  • thing:namespace
  • thing:name

Resolves: #1931

@thjaeckle thjaeckle added the bug label Apr 29, 2024
@thjaeckle thjaeckle added this to the 3.5.5 milestone Apr 29, 2024
@thjaeckle thjaeckle self-assigned this Apr 29, 2024
@thjaeckle thjaeckle force-pushed the bugfix/placeholder-in-connection-filter branch from e9087c6 to a98c611 Compare April 30, 2024 06:59
@thjaeckle
Copy link
Member Author

thjaeckle commented Apr 30, 2024

@alstanchev @kalinkostashki Could you please have a look?
Some "inconsistency" I noticed (I expected that to work, but it didn't) when trying to formulate e.g. that I only want to be notified about "feature messages" via:

_/_/things/live/messages?filter=exists(feature:id)

Copy link
Contributor

@alstanchev alstanchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@thjaeckle thjaeckle merged commit 3aca212 into eclipse-ditto:master Apr 30, 2024
3 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Using some placeholders in RQL "filters" for connection "targets" is not possible
2 participants