#1650 provide WoT TM validation #1936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thjaeckle
force-pushed
the
wot-tm-validation
branch
8 times, most recently
from
7230638 to
4a8e4b6
Compare
thjaeckle
force-pushed
the
wot-tm-validation
branch
2 times, most recently
from
45ae2b5 to
49b206e
Compare
thjaeckle
force-pushed
the
wot-tm-validation
branch
3 times, most recently
from
c0ab94d to
c05c867
Compare
* restructuring of "ditto-wot" module to enable re-usability of non-pekko/non-Ditto specifics * adding "validator" concept and first sample implementation (WIP) Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
…hingModel Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
…desired properties validation * taking care of e.g. "ditto:category" defined * first validation error will provide the error output (which is for now simpler and results in quicker obtained validation errors) Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
* validating features and properties as part of "modify thing" * handling "ditto:category" correctly * ensuring completeness of defined features * validation on creation/modification * of thing * of attributes * on attribute * on features * on feature Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
…property Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
* enforce modifying thing definition + feature definition * enhance configuration options
…the thing for validationError paths
…their responses * also updated some dependencies * simplified DefaultWotThingModelValidator a little
…iding "type" (valid for e.g. "oneOf") use * update json-schema-validator library
…ation in smaller pieces * strict split between config reading in DefaultWotThingModelValidation and static functionality in Internal* classes
* based on either DittoHeaders or on ThingDefinition/FeatureDefinition URLs
* fixed and harmonized other traces while doing that in order to get correct parent hierarchy of spans
…ased on the WoT model * restructured some too long methods * fixed remaining TODOs
* also for dynamic part * changed config structure a bit in order to better fit Helm YAML config
…e corner cases * e.g. deeply nested updates, removing definition via PATCH * enabled WoT based validation by default
* first choosing potentially new definition and only as fall-back the old one
thjaeckle
force-pushed
the
wot-tm-validation
branch
from
dbc03b1 to
608894f
Compare
|
FMPOV ready to be reviewed :) It is of course a massively huge PR - let's discuss how to review it most efficiently @alstanchev @kalinkostashki |
|
@alstanchev did you manage to have a look? would want to merge this PR soon .. |
|
yes, LGTM 👍 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open points:
oneOfforDataSchema- validation must only match "one of" the provided schemasResolves: #1650