Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[2.7] fix #1596 Major performance issue in case of many new entities - backport from master #1860

Merged
merged 3 commits into from
Apr 13, 2023

Conversation

Zuplyx
Copy link
Contributor

@Zuplyx Zuplyx commented Apr 12, 2023

Backport of #1843 from master to 2.7.
For details see the PR to master.

Zuplyx and others added 2 commits April 12, 2023 09:01
instead of a linear search

Signed-off-by: Patrick Schmitt <Patrick.Schmitt@cpb-software.com>
instead of a linear search

Signed-off-by: Patrick Schmitt <Patrick.Schmitt@cpb-software.com>
Copy link
Contributor

@rfelcman rfelcman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one note about code styling. Please reformat it into stlyle like #1843
e.g.

if () {
}

instead of

if ()
{
}

Thank You

Signed-off-by: Patrick Schmitt <Patrick.Schmitt@cpb-software.com>
@Zuplyx
Copy link
Contributor Author

Zuplyx commented Apr 12, 2023

I've corrected the formatting. I accidentally used the wrong auto-formatting.

@patric-r
Copy link

patric-r commented Apr 12, 2023

@rfelcman Can you have a look at the checks which seem to fail because of a build environment issue?
/home/runner/work/eclipselink/eclipselink/antbuild.xml:455: Maven 3 not found. Build won't run if Maven 3 not installed and M2_HOME properly set!.

@Zuplyx
Copy link
Contributor Author

Zuplyx commented Apr 12, 2023

There also seems to be a problem with the Jenkins-Builds: The builds for the PR are waiting for the nightly-build to complete, which seems to be stuck in a loop with the error message kubernetes resource quota exceeded.

@rfelcman
Copy link
Contributor

@rfelcman Can you have a look at the checks which seem to fail because of a build environment issue? /home/runner/work/eclipselink/eclipselink/antbuild.xml:455: Maven 3 not found. Build won't run if Maven 3 not installed and M2_HOME properly set!.

I know. Fix for this issue is part of #1859

@rfelcman
Copy link
Contributor

There also seems to be a problem with the Jenkins-Builds: The builds for the PR are waiting for the nightly-build to complete, which seems to be stuck in a loop with the error message kubernetes resource quota exceeded.

I see I restarted it (https://ci.eclipse.org/eclipselink/job/eclipselink-pull-request-verifier/job/PR-1860) manually.

Copy link
Contributor

@rfelcman rfelcman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rfelcman rfelcman merged commit cbec1c7 into eclipse-ee4j:2.7 Apr 13, 2023
@Zuplyx Zuplyx deleted the 2.7-backport branch April 13, 2023 07:44
@patric-r
Copy link

@rfelcman Thanks for your support.
Any chance for a new 2.7 release soon?

@rfelcman
Copy link
Contributor

@rfelcman Thanks for your support. Any chance for a new 2.7 release soon?

If nightly build will pass https://ci.eclipse.org/eclipselink/job/eclipselink-nightly-2.7/ there will be Maven snapshot and nightly at
https://jakarta.oss.sonatype.org/content/groups/staging/org/eclipse/persistence/eclipselink/2.7.13-SNAPSHOT/
https://www.eclipse.org/eclipselink/downloads/nightly.php (2.7.13)
Final release during 1-3 months.

@patric-r
Copy link

Hi @rfelcman,
2 months later and after 4.0.2 has been released with the fix - is there already an ETA for a new 2.7 release?

@rfelcman
Copy link
Contributor

About next 2.7.13 there is no any ETA yet.

@patric-r
Copy link

@rfelcman 3 months have now passed.
As you estimated "1-3 months" for a new 2.7.x release since the fix, we're now looking forward towards a new release on short-term in order to benefit from our contribution.

@patric-r
Copy link

@rfelcman Any updates regarding this?

@rfelcman
Copy link
Contributor

rfelcman commented Jul 25, 2023

@rfelcman Any updates regarding this?

See
https://github.com/eclipse-ee4j/eclipselink/releases/tag/2.7.13-RC1
https://eclipse.dev/eclipselink/downloads/milestones.php (2.7.13 section with RC1)
and Maven Central for 2.7.13-RC1 (in progress will there during 2 hours)

If everything goes well will final version will be on Thursday 27-Jul-2023.

@patric-r
Copy link

@rfelcman These are great news, thank you!

@rfelcman
Copy link
Contributor

FYI: Final 2.7.13 is out

@patric-r
Copy link

Thanks, @rfelcman

We're already started testing this release.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants