Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove some more instances of access controller (Security manager) #24994

Merged
merged 19 commits into from
Jun 22, 2024

Conversation

arjantijms
Copy link
Contributor

No description provided.

dmatej and others added 18 commits June 2, 2024 16:03
- There is already the shutdown hook registered few lines above even with more
  "radical" parameters (kill, force).

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
- when buffer is full, every new log will be blocked. If this happens for
  records comming from the thread moving the server.log file, everything
  stops forever.

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
- Deadlock can be caused when we are rolling the file with the full log record
  buffer AND we log anything from this thread.
- Solution: if you really need to log something, use asycnhronous thread.
- Under a heavy load (1 record every 3 microseconds) such log record can occur
  even after another 5000 other records in the buffer or trying to be added to
  the buffer. It is just another one.

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
For apps deployed via Admin Console, the uploaded file was copied to a temp file, 
which contained a random string. Now, the temp directory has a random string, 
but the file in it has the same name.
Context root is generated from the file name and doesn't include 
a random string with this commit.
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
Fixed deadlock when rolling the file under a heavy load
The catch is not required to stop GF instance
- also remove after file is uploaded
- improve file handling for uploaded files
- give an error in GUI if IOException
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
…ult-context-root

Context root doesn't include a random string
Instead of just ignoring the first line. Just in case :)
…tserv-suspend

Fix an issue with bin/startserv --suspend
@arjantijms arjantijms added this to the 8.0.0 milestone Jun 22, 2024
@arjantijms arjantijms requested a review from dmatej June 22, 2024 11:03
@arjantijms arjantijms self-assigned this Jun 22, 2024
@arjantijms arjantijms merged commit 90f5e1f into eclipse-ee4j:8.0 Jun 22, 2024
2 checks passed
@arjantijms arjantijms deleted the 8_0_access_controller_4 branch June 22, 2024 14:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants