-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Remove some more instances of access controller (Security manager) #24994
Merged
arjantijms
merged 19 commits into
eclipse-ee4j:8.0
from
arjantijms:8_0_access_controller_4
Jun 22, 2024
Merged
Remove some more instances of access controller (Security manager) #24994
arjantijms
merged 19 commits into
eclipse-ee4j:8.0
from
arjantijms:8_0_access_controller_4
Jun 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- There is already the shutdown hook registered few lines above even with more "radical" parameters (kill, force). Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
- when buffer is full, every new log will be blocked. If this happens for records comming from the thread moving the server.log file, everything stops forever. Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
- Deadlock can be caused when we are rolling the file with the full log record buffer AND we log anything from this thread. - Solution: if you really need to log something, use asycnhronous thread. - Under a heavy load (1 record every 3 microseconds) such log record can occur even after another 5000 other records in the buffer or trying to be added to the buffer. It is just another one. Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
For apps deployed via Admin Console, the uploaded file was copied to a temp file, which contained a random string. Now, the temp directory has a random string, but the file in it has the same name. Context root is generated from the file name and doesn't include a random string with this commit. Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
Fixed deadlock when rolling the file under a heavy load
The catch is not required to stop GF instance
- also remove after file is uploaded - improve file handling for uploaded files - give an error in GUI if IOException Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
Webpage update for 7.0.15
…ult-context-root Context root doesn't include a random string
Instead of just ignoring the first line. Just in case :)
…tserv-suspend Fix an issue with bin/startserv --suspend
8_0_access_controller_4
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.