Using release instead of source+target, removing ldapbp module #25096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ugin) Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
- The rest of GF uses just Java 11 as required java version Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
- I just fixed its build in 2022, but it was never even tested. - The --add-export instruction is in collision with the <release> element set for compiler. Obviously it would cause problems in the future. Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
- on JDK11 is missing the Microprofile support Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Merged
pzygielo
approved these changes
Aug 14, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
source+targetare deprecated, so I switched toreleaseexporting a package from system module java.naming is not allowed with --release- and Maven is right, exporting system modules is evil ;-) . This module is also visibly buggy when you just read its code, so I removed it. No harm for GlassFish and I don't expect anybody would use it.