Spotted bugs in tests #25115
Merged
Spotted bugs in tests #25115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dmatej
commented
Aug 25, 2024
dmatej
commented
- detected by SpotBugs
- unused ServiceLocator in hk2 config generator tests
- known null value - was a bad practice. The field value could be changed in general but was used as if it could not be changed. But if it could not be changed, it is known null and there is no reason to check it with assert. Or if it could be changed, then it should not be public.
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
- It is right, it is a public field and it is changed from the outside, maybe even by multiple threads; not true in the unit test, but ... Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
avpinchuk
approved these changes
Aug 25, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.