NetUtils revisited #25117
Merged
NetUtils revisited #25117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dmatej
commented
Aug 26, 2024
dmatej
commented
- See individual commit messages, however review whole diff
- Deleted, renamed, simplified methods, added or revisited few javadocs
- Fixed one possible NPE
- Removed dead code.
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
- It doesn't have reason the log it in the original method in unexpected situations (I wanted just to check if the port is free) - However it is an important warning. - Idea: CLI commands should report detected basic issues which might cause problems with CLI command execution. Server instances should do that on startup too. Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
- Unused and commented out code, formatting Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
- getFreePort now throws ISE on error
- originally returned zero
- the only usage is in DomainPortValidator, however now it can be used on
other places too.
- Order of methods for better orientation
- first methods using other methods in the same class
- first ports, then hosts
- Removed unused methods
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
avpinchuk
approved these changes
Aug 27, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.