Issue #24900 add a few unit tests for ManagedConnectionImpl and ConnectionHolder to understand associateConnection logic #25176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, we had a broken metadata file in maven cache, that crashed your build, I have restarted the job now |
escay
force-pushed
the
issue_24900_associateConnection
branch
from
fd51567
to
6b7cd31
Compare
dmatej
reviewed
Oct 17, 2024
appserver/jdbc/jdbc-ra/jdbc-core/src/main/java/com/sun/gjc/spi/JdbcObjectsFactory.java
Outdated
Show resolved
Hide resolved
associateConnection logic which is used by ConnectorXAResource in connector-runtime
escay
force-pushed
the
issue_24900_associateConnection
branch
from
27a93f0
to
3ab0e59
Compare
dmatej
approved these changes
Oct 31, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote a few unit tests to start to understand associateConnection logic which is used by ConnectorXAResource in connector-runtime.
Added some javadoc to understand ManagedConnectionImpl parameters.
Added a listener null check and added unregister listener logic which seemed to be missing.
Removed a boolean parameter from setActive(true) which was always true.