Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, failed deployment failed to trigger some events that usually happen during undeployment. This fixes the error handler to properly clean everything up and trigger events that correspond to
deploy
andundeploy
called in a sequence.Tested with:
deploy --name app1 --contextroot / app.war && deploy --name app2 --contextroot / app.war
- deploys an app with name "app1" (success), then deploys the same app, same context root, with name "app2" - failure because the context root must be uniquedeploy --name app1 app.war && undeploy app1
-Without this change, the events trigger :
With this change, all relevant events are triggered: