ParamConverterFactory should use LinkedHashSet to preserve ordering #3955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clipse-ee4j#3670) Signed-off-by: Christian Kaltepoth <christian@kaltepoth.de>
arjantijms
approved these changes
Oct 4, 2018
|
Maybe it's unrelated, but this test is failing now: |
|
shall be unrelated.. however the full PR duplicates #3925 or am I missing something? But explanation here is really brilliant because I was investigating this yesterday and I was not sure if it helps (LinkedHashSet I mean) |
senivam
approved these changes
Oct 4, 2018
|
but this gained 2 approves |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request has been migrated from jersey/jersey#3669. It fixes the first issue described in #3670.
In a nutshell: If you provide a custom
ParamConverterProviderfor a data type for which there is also a builtin one provided by Jersey, a random one wins and gets executed. This changes even between deployments. This issue is caused by aHashSetinParamConverterFactorywhich should actually be aLinkedHashSetto preserve the ordering.