Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Prevent race condition in entity filtering #4204

Merged
merged 1 commit into from
Aug 12, 2019
Merged

Prevent race condition in entity filtering #4204

merged 1 commit into from
Aug 12, 2019

Conversation

jansupol
Copy link
Contributor

Signed-off-by: Jan Supol jan.supol@oracle.com

@jansupol
Prevent race condition in entity filtering
1ecbc02 
Signed-off-by: Jan Supol <jan.supol@oracle.com>
@jansupol
Copy link
Contributor Author

Unfortunately, I was not able to come up with a solid reproducer/test.

However, when one thread stored a graph graphProvider.getOrCreateEntityGraph(entityClass, forWriter), another thread used the graph before the graph was populated by the first thread. It resulted in a situation where everything was filtered out in an HTTP response, as the unpopulated graph did not contain the entities that should not have been filtered out.

@jansupol
Copy link
Contributor Author

Fixes #4189 #4187

tomas-langer
tomas-langer approved these changes Aug 12, 2019
View reviewed changes
Copy link
Contributor

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as there are no side effects to creating a new instance of the EntityGraph

@senivam senivam merged commit 0a867e9 into eclipse-ee4j:master Aug 12, 2019
@jansupol jansupol added this to the 2.29.1 milestone Aug 12, 2019
pa314159 pushed a commit to pa314159/jersey that referenced this pull request Aug 28, 2019
@jansupol @pa314159
Prevent race condition in entity filtering (eclipse-ee4j#4204)
8af5e69 
Signed-off-by: Jan Supol <jan.supol@oracle.com>
This was referenced Jun 26, 2021
Merged
Open
Open
Merged
Open
This was referenced Aug 5, 2021
Closed
Closed
This was referenced Sep 5, 2021
Merged
Merged
Merged
This was referenced Oct 4, 2021
Merged
Merged
This was referenced Oct 18, 2021
Open
Open
This was referenced Oct 21, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Oct 21, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
@renovate renovate bot mentioned this pull request Jan 10, 2022
Open
1 task
This was referenced Mar 7, 2022
Closed
Closed
This was referenced Mar 15, 2022
Merged
Merged
This was referenced Apr 17, 2022
Closed
Closed
This was referenced May 3, 2022
Open
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request May 12, 2022
Closed
1 task
@renovate renovate bot mentioned this pull request Sep 23, 2022
Merged
1 task
@mend-for-github-com mend-for-github-com bot mentioned this pull request Dec 5, 2022
Open
@renovate renovate bot mentioned this pull request Feb 11, 2023
Merged
1 task
@renovate renovate bot mentioned this pull request May 11, 2023
Open
1 task
@renovate renovate bot mentioned this pull request Jul 6, 2023
Open
1 task
@renovate renovate bot mentioned this pull request Aug 30, 2023
Merged
1 task
@mend-for-github-com mend-for-github-com bot mentioned this pull request Dec 4, 2023
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request Jan 11, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@senivam senivam senivam approved these changes

@tomas-langer tomas-langer tomas-langer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.29.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jansupol @tomas-langer @senivam