Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow for using HeaderDelegateProvider service #4276

Merged
merged 2 commits into from
Oct 29, 2019

Conversation

jansupol
Copy link
Contributor

if CommonProperties#METAINF_SERVICES_LOOKUP_DISABLE is not true

Signed-off-by: Jan Supol jan.supol@oracle.com

…TAINF_SERVICES_LOOKUP_DISABLE is not true

Signed-off-by: Jan Supol <jan.supol@oracle.com>
@jansupol
Copy link
Contributor Author

fixes #4266

@jansupol jansupol self-assigned this Sep 27, 2019
@jansupol jansupol added the spi label Sep 27, 2019
Copy link
Contributor

@senivam senivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Jan Supol <jan.supol@oracle.com>
@jansupol jansupol requested a review from Verdent October 4, 2019 09:26
@jansupol jansupol merged commit 82a85a1 into eclipse-ee4j:master Oct 29, 2019
@jansupol jansupol added this to the 2.30 milestone Nov 5, 2019
@pdudits
Copy link
Contributor

pdudits commented Nov 15, 2019

I just noticed that 82a85a1 breaks 'unit' tests jersey-rest-client-tck, but the output is quite silent about the actual cause:

[ERROR] Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 4.254 s <<< FAILURE! - in org.glassfish.jersey.restclient.ConsumesAndProducesTest
[ERROR] testWithoutEntityActualValue(org.glassfish.jersey.restclient.ConsumesAndProducesTest)  Time elapsed: 3.544 s  <<< ERROR!
javax.ws.rs.WebApplicationException: Unknown error, status code 500
        at org.glassfish.jersey.restclient.ConsumesAndProducesTest.testWithoutEntityActualValue(ConsumesAndProducesTest.java:64)
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.065 s <<< FAILURE! - in org.glassfish.jersey.restclient.RestClientModelTest
[ERROR] testGetIt(org.glassfish.jersey.restclient.RestClientModelTest)  Time elapsed: 0.057 s  <<< ERROR!
javax.ws.rs.WebApplicationException: Unknown error, status code 500
        at org.glassfish.jersey.restclient.RestClientModelTest.testGetIt(RestClientModelTest.java:47)

pdudits added a commit to pdudits/patched-src-jersey that referenced this pull request Nov 18, 2019
@jansupol jansupol deleted the runtimedelegateheader branch November 18, 2019 20:11
@jansupol
Copy link
Contributor Author

I thought the TCK tests are run on Travis

@jansupol
Copy link
Contributor Author

@pdudits the unit tests pass for me with 82a85a1. Are you sure it is this commit that breaks the unit tests? The unit tests are run on Travis just fine.

@pdudits
Copy link
Contributor

pdudits commented Nov 18, 2019

I'll double check tomorrow. Could also be Windows thing...

@pdudits
Copy link
Contributor

pdudits commented Nov 19, 2019

Sorry for false alarm, my fault. I was running mvn -pl :jersey-mp-rest-client -am -amd clean install and that skips test-framework, so I didn't compile all of the changes required for that commit.

@Verdent
Copy link
Member

Verdent commented Nov 19, 2019

That is great to hear :-) I was a bit puzzled why is it not working.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants