Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Assure that exception in async interceptor doesn't prevent completion #4292

Merged

Conversation

pdudits
Copy link
Contributor

@pdudits pdudits commented Oct 15, 2019

I accidentally run Jersey REST Client against TCK version 1.1, which isn't binary comatible.

AsyncMethodTest hung with it, because AsyncInvocationInterceptor didn't yet have method removeContext, and therefore this invocation

asyncInterceptors.forEach(AsyncInvocationInterceptor::removeContext);

was throwing AbstractMethodError. This again happened in exceptionally callback, causing resulting CompletableFuture to never complete.

The change will propagate any AsyncInvocationInterceptor failure to completion result.

Signed-off-by: Patrik Dudits <patrik.dudits@payara.fish>
@jansupol jansupol merged commit 7b3a86b into eclipse-ee4j:master Oct 17, 2019
@senivam senivam added this to the 2.29.2 milestone Oct 21, 2019
@jansupol jansupol modified the milestones: 2.29.2, 2.30 Nov 5, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants