Execute tests in servlet-2.5-mvc-3 #4473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
|
Same issue in Travis, as far as I can see. I will try to fix it. |
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
|
I deployed the war file in a local Jetty 9 and I saw the charset was not specified in the header. The test was reading the page. As the charset was not specified it was reading it as UTF-8 by default. I had to add a filter to explicitly set the header with the required charset. |
This reverts commit 8daf7b8. Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
jbescos
force-pushed
the
servlet-2.5-mvc-3
branch
from
ae9609d to
db3bfa6
Compare
jansupol
approved these changes
May 20, 2020
senivam
approved these changes
May 20, 2020
This was referenced Jun 26, 2021
This was referenced Jul 6, 2021
This was referenced Aug 5, 2021
This was referenced Aug 30, 2021
1 task
This was referenced Oct 4, 2021
This was referenced Oct 18, 2021
1 task
This was referenced Oct 21, 2021
Closed
1 task
1 task
This was referenced Mar 7, 2022
This was referenced Mar 15, 2022
This was referenced Apr 17, 2022
This was referenced May 3, 2022
1 task
This was referenced Oct 19, 2022
1 task
1 task
1 task
1 task
This was referenced Apr 13, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locally I'm having an error in one test that checks one ISO character encoding, but it seems it is running fine in Travis.