Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make Kryo use setRegistrationRequired(true) by default #4541

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

jansupol
Copy link
Contributor

@jansupol jansupol commented Aug 4, 2020

Signed-off-by: jansupol jan.supol@oracle.com

@jansupol
Copy link
Contributor Author

jansupol commented Aug 4, 2020

See EsotericSoftware/kryo#398

@@ -1,5 +1,5 @@
/*
* Copyright (c) 2015, 2019 Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2020 Oracle and/or its affiliates. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be 2015, 2020?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is a new file. Git thinks the file was renamed and changed, but the previous file was erased and the new file created. The files are completely different, with different purpose

Signed-off-by: jansupol <jan.supol@oracle.com>
Copy link
Contributor

@senivam senivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, looks good to me

@senivam senivam merged commit fb80651 into eclipse-ee4j:master Aug 5, 2020
@jansupol jansupol deleted the kryo branch August 17, 2020 09:19
@jansupol jansupol added this to the 2.32 milestone Sep 22, 2020
@jansupol jansupol self-assigned this Sep 22, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants