-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Remove com.sun.org.apache.xml.internal #4812
Conversation
Generated in jersey/examples/extended-wadl-webapp/target/classes/resourcedoc.xml it contains the file created with and without my changes. |
c7e62cb
to
8ad870b
Compare
After updating the version pax.exam.version I don't get the maven error, so it is possible to run the tests locally and it is working. |
2830a98
to
53c5032
Compare
CQ # |
02e2825
to
3309d16
Compare
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
Signed-off-by: Maxim Nesen <maxim.nesen@oracle.com>
Signed-off-by: Maxim Nesen <maxim.nesen@oracle.com>
3309d16
to
b6dd231
Compare
Signed-off-by: Maxim Nesen <maxim.nesen@oracle.com>
OSGi example bundle fix Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
352fa38
to
a71a763
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Currently when you compile jersey/ext/wadl-doclet with JDK 11+ it gets the next error:
This PR is about removing that com.sun.org.apache.xml.internal.serialize.
There is one module in Jersey that tests wadl-doclet in jersey/examples/extended-wadl-webapp and it generates the resourcedoc.xml. I am attaching both, with and without my changes.
I set this as a draft because in my computer I am getting one error running the tests that seems to be unrelated:
java.io.IOException: Error resolving artifact org.ops4j.pax.exam:pax-exam-inject:jar:4.13.1: Could not transfer artifact org.ops4j.pax.exam:pax-exam-inject:jar:4.13.1 from/to central (http://repo1.maven.org/maven2/): Failed to transfer file: http://repo1.maven.org/maven2/org/ops4j/pax/exam/pax-exam-inject/4.13.1/pax-exam-inject-4.13.1.jar. Return code is: 501 , ReasonPhrase:HTTPS Required.
I will change it to ready for review once Travis or Jenkins shows successful results.