-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Netty Connector doesn't support Followredirects #5048
Conversation
d09bbb1
to
cde8346
Compare
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. It would even be better if a redirect loop would have been detected, something like org.glassfish.jersey.jdk.connector.internal.RedirectHandler implements.
@@ -46,21 +49,27 @@ | |||
*/ | |||
class JerseyClientHandler extends SimpleChannelInboundHandler<HttpObject> { | |||
|
|||
private static final String LOCATION_HEADER = "Location"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
javax.ws.rs.core.HttpHeaders.Location
Thanks for the comments, I will work on that. I was not aware about the redirect handler, and it looks I should use it. |
b37494b
to
70a9896
Compare
* @see org.glassfish.jersey.client.ClientProperties#FOLLOW_REDIRECTS | ||
* @see org.glassfish.jersey.netty.connector.internal.RedirectException | ||
*/ | ||
public static final String MAX_REDIRECTS = "jersey.config.client.NettyConnectorProvider.maxRedirects"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please update the properties documentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, lets wait for a green build just in case I did something wrong.
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
Relates to #5045