-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Remove Guava under version 24 #5175
Conversation
jbescos
commented
Oct 11, 2022
•
edited
Loading
edited
- Some dependencies that bring Guava under version 24 have exclusions. Good news is that we only use them for testing/exampling purposes. Lets see if tests are passing with that exclusion.
- With others like testng, just updating the version brings a correct Guava.
- Testng new version works with arquilian-testng in alpha version unfortunately. I hope this is not a problem.
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
918cb8a
to
a7b803e
Compare
The build is failing, but when I check the output the maven part is success:
|
a7b803e
to
f4214e3
Compare
@jbescos build fails for JDK 8 only, here is the log:
|
Requirements: |
7a8d538
to
9fc4ef9
Compare
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
9fc4ef9
to
cbd0c3d
Compare
I have tuned the versions to work fine with JDK8 and we also don't need to use an alpha version of arquilian. |
These are the guava dependencies that we will have with the fix:
This is what we have now in master:
|
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
3458ee3
to
8557364
Compare
|
c9e2ea8
to
21c2ed9
Compare
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
21c2ed9
to
302ca6a
Compare
2498854
to
95f40d5
Compare
95f40d5
to
6ac6520
Compare