Support multipart by Jetty & Netty #5436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansupol
force-pushed
the
multipart.support.connectors
branch
3 times, most recently
from
fcc1bb1 to
2318e9e
Compare
Signed-off-by: jansupol <jan.supol@oracle.com>
jansupol
force-pushed
the
multipart.support.connectors
branch
from
2318e9e to
ede6c5f
Compare
senivam
approved these changes
Oct 17, 2023
jbescos
reviewed
Oct 17, 2023
| @@ -468,9 +469,23 @@ public void run() { | |||
| } | |||
| }); | |||
|
|
|||
| if (entityWriter.getType() != NettyEntityWriter.Type.DELAYED) { | |||
| entityWriter.flush(); | |||
| headersSet.await(); | |||
There was a problem hiding this comment.
As we have to wait anyway, do we really need the executorService?. Maybe we can get rid of it and also the CountDownLatch.
There was a problem hiding this comment.
Ignore it, the countdownlatch is different.
jbescos
approved these changes
Oct 17, 2023
This was referenced Oct 20, 2023
1 task
This was referenced Nov 13, 2023
This was referenced Nov 22, 2023
This was referenced Jan 16, 2024
1 task
This was referenced Apr 13, 2024
Closed
1 task
1 task
This was referenced Jan 9, 2025
1 task
This was referenced Mar 13, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.