-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Use string as hashcode in lock map in HttpUrlConnectorProvider #5815
Use string as hashcode in lock map in HttpUrlConnectorProvider #5815
Conversation
please try to sign ECA (Wiki) to merge your PR. Otherwise, we cannot accept it. And thank you for the fix! |
I've signed the ECA :-) |
@ripdajacker Thank you for this. |
That seems to be for the 2.1 branch. My fix does not fix the concurrency implications of using locks but it removes the very subtle potential DNS lookup when attempting to require a lock. I am certain there are better ways to improve performance, but cannot see how the linked PR fixes the issue at hand. |
@ripdajacker Sorry a wrong link, midnight work... #5794 should be the fix. |
That will probably do, will it be merged to 3.1 too? |
@ripdajacker yes, before every release of 3.0.x and 3.1.x changes from 2.x and 3.0 branches are propagated respectively. |
@senivam Cool, good to know :) Is there an ETA? I'll close the PR then. |
See issue: #5814
This patch changes the key type of the
locks
map inorg.glassfish.jersey.client.HttpUrlConnectorProvider
to avoid callinggetInetAddress
on the URL's every time a URL connection is opened.This is an issue when using the built-in JVM http proxy mechanism.