Allow to configure Jackson's JaxRSFeature on Jersey DefaultJacksonJaxbJsonProvider #5816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bJsonProvider Signed-off-by: jansupol <jan.supol@oracle.com>
Signed-off-by: jansupol <jan.supol@oracle.com>
Signed-off-by: jansupol <jan.supol@oracle.com>
senivam
approved these changes
Dec 16, 2024
jbescos
reviewed
Dec 17, 2024
| } | ||
| } | ||
|
|
||
| private Optional<List<JaxRSFeatureState>> jaxRSFeature = Optional.empty(); |
There was a problem hiding this comment.
Does it makes sense to remove Optional and just have the list?:
private final List<JaxRSFeatureState> jaxRSFeatures = new ArrayList<>();
If empty, hasJaxrsFeature returns false
I found this is more understandable, although this is only a personal opinion.
jbescos
approved these changes
Dec 17, 2024
1 task
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.