Reviewed and fixed osgi values in manifest and module-info

[dmatej]

• This PR fixes issue discovered when I was working on Redesign of GlassFish bootstrap glassfish#25183 where I introduced another piece of JPMS. The impl package was missing in module-info, however it is explicitly used.
• see https://github.com/eclipse-ee4j/orb-gmbal/tree/master/impl/src/main/java/org/glassfish/gmbal - there are three subpackages: impl, main, typelib - exporting just org.glassfish.gmbal in fact doesn't export anything (impl.trace is ok but I don't think we need to export it).
• similar problem is with osgi
  • Felix plugin does better job with defaults; by default it would not export just impl and internal packages if I remember well.

Change in imports+exports: 4.0.4 instead of 4.0.4.SNAPSHOT, so it can be locally tested in snapshots together with GlassFish as this is default and consistent behavior.

Packages:

• API:

  • org.glassfish.gmbal - no change, exported
  • org.glassfish.gmbal.util - internal package used just in local ManagedObjectManagerFactory, change: both export and import stopped (just module-info had this issue).
  • org.glassfish.pfl.tf.timer.spi - no change, exported

• IMPL

  • The only place I have found its usage is the API module.
  • org.glassfish.gmbal - change: contains just subpackages, so removed from manifest.
  • org.glassfish.gmbal.impl - change: now it is exported in module-info as it is explicitly used by API (reflection). Changed also uses in manifest (generated by Felix).
  • org.glassfish.gmbal.impl.trace - change: not used outside IMPL -> not exported, not imported
  • org.glassfish.gmbal.main - no change, not exported
  • org.glassfish.gmbal.typelib - no change, not exported

[pzygielo]

Can you open new PR for module-info only, please?

[dmatej]

Can you open new PR for module-info only, please?

The PR consists of two standalone commits - one is fixing the issue, second makes it testable. Without the second one you cannot test it with GlassFish, so it makes sense just together.

[dmatej]

Can you open new PR for module-info only, please?

I will come back to this today, the PR works but I think jpms and osgi should be in sync and the aren't. But I am sure it should be just a single PR.

EDIT: TODAY I meant in January? 👎
EDIT: Rebased and revisited, however I will rebase and retest the whole set of dependencies together with GlassFish for sure.