Fix#8 the default value of keepgenerated is false only in JDK 6.

[hs536]

The default value for JSP keepgenerated should be false in JDK 6 or later, but only in JDK 6.

Signed-off-by: hs536 sawamura.hiroki@fujitsu.com

closes #8

[joakime]

With the next version of Jakarta EE (Jakarta EE 10), there is a strong chance that it will have Java 11 as the minimum supported version of Java (it's being voted on right now).
This JVM specific concept in EmbeddedServletOptions will probably just be removed at that point.

[hs536]

@joakime @arjantijms
This PR was finally fixed by removing the special handling with JDK 6. Is there anything else I can do?

[joakime]

@markt-asf you good with this change?

[markt-asf]

I have no objection but my opinion shouldn't count much as I'm not involved in the Jakarta implementation work at Eclipse.
On a mostly unrelated topic, I did notice that WASP is still using the org.apache.jasper package. Changing the package name is long overdue in my view.

[joakime]

On a mostly unrelated topic, I did notice that WASP is still using the org.apache.jasper package. Changing the package name is long overdue in my view.

Yeah, that should be a new issue / pr IMO

[joakime]

@markt-asf opened issue about package namespace as #29

[joakime]

@arjantijms you have any objections with this PR?

[arjantijms]

@joakime it looks fine, indeed no need to keep anything JDK 6 around.

A tiny remark, and that's here:

private boolean keepGenerated = false;

false is already the default for a boolean field, so there's no need to set it explicitly.

[hs536]

false is already the default for a boolean field, so there's no need to set it explicitly.

Yes, I think the default values are defined clearly because they correspond to jasper options.

wasp/src/main/java/org/apache/jasper/EmbeddedServletOptions.java

Lines 59 to 72 in 4006669

	/**
	* Do you want to keep the generated Java files around?
	*/
	private boolean keepGenerated = false;
	/**
	* If class files are generated as byte arrays, should they be saved to disk at the end of compilations?
	*/
	private boolean saveBytecode = false;
	/**
	* Should white spaces between directives or actions be trimmed?
	*/
	private boolean trimSpaces = false;

[hs536]

@joakime Is there anything else I can do to merge this fix?

[arjantijms]

It looks good, thanks! We may pretty soon indeed set the defaults to JDK 11.