Fix #31 JSP compilation error on JDK 9 or higher #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kosakak <kosaka.koki@fujitsu.com>
|
Thanks! Looks good. For WaSP we can probably set the default to JDK 11, but this will work for now. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31
I propose to set the default value of
compilerSourceVMandcompilerTargetVMto1.8and remove the code that detects those values.The reason is that
wasp-3.0.1.jaris built with JDK 8 and cannot run on JDK 7 or earlier version.Signed-off-by: kosakak kosaka.koki@fujitsu.com