Fix #38 JSPC compile fails on JDK11 without compilerSourceVM and compilerTargetVM options.

[kaido207]

• Fixes JSPC compile fails on JDK11 without compilerSourceVM and compilerTargetVM options. #38.
• And related compilerSourceVM/compilerTargetVM cannot be set to JDK 9 or higher #28.

Signed-off-by: kaido207 kaido.hiroki@fujitsu.com

[joakime]

Skip all of the minimum jvm checks, they are wrong for Java 11+. Best to just let javac fail.

Food for thought.

If you are on Java 11 runtime, which this version of wasp has set as a minimum support level, then you only have Java source/target of 6 (or 1.6) as a minimum.
If you are on Java 17 runtime, which this version of wasp has to certify via the TCK on, then you only have Java source/target of 7 (or 1.7) as a minimum.

I'd be more curious as to what would happen if we instead had NO predefined or hard-coded source/target defined.
Make it use the runtime source/target (just like javac does).
This doesn't mean remove support for defining source/target if the user wants to, but why hard code it in the first place?

[kaido207]

@joakime Completely agree with you. I'd changed my proposal.

[kaido207]

@joakime Is there anything else I can do?

[arjantijms]

It looks good to me, if @joakime doesn't reply we can merge it by lazy consensus.

[joakime]

I'm in a mental fog (covid). Do what you want here.

[kaido207]

Are there any other suggestions to merge this patch?

[arjantijms]

@kaido207

Are there any other suggestions to merge this patch?

There's a merge conflict now. Sorry, can you reapply the patch?

[kaido207]

@arjantijms Sure, I done.

[arjantijms]

@kaido207 thanks!