Set JarURLConnection.useCaches to false in Compiler.isOutDated(). #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kaido207 <kaido.hiroki@fujitsu.com>
|
IIRC, this changed again in Java 17, which uses zipfs instead of JarURLConnection for the classloader now. |
|
@joakime This behavior remains the same in Java 17. so it should be addressed, especially for Jakarta EE 10, the minimum runtime version is Java 11. |
|
Are there any other suggestions to merge this patch? |
arjantijms
approved these changes
Apr 28, 2022
|
Thanks @kaido207 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The jar file included in the JSP application remains locked if
JarURLConnection.useCachesis true when the connection is closed.https://github.com/openjdk/jdk/blob/739769c8fc4b496f08a92225a12d07414537b6c0/src/java.base/share/classes/sun/net/www/protocol/jar/JarURLConnection.java#L105-#L118
In Windows, user cannot remove the file until restarting JVM.
Signed-off-by: kaido207 kaido.hiroki@fujitsu.com