-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Move all products to dedicated folder #114
Conversation
The org.eclipse.equinox.p2.director.app.product has to be changed to be based on Plug-ins. Otherwise we always have issues with features in other repos that include Plug-ins from this repo. |
@HannesWell building products can add considerably to build times, I thin we should use a profile to explicitly enable that. |
That's right. On other hand building them (at least occasionally) makes sure they continue to work. Maybe it would be reasonable to only build them in I-builds? |
7d2f103
to
3c74328
Compare
3c74328
to
6004f84
Compare
6004f84
to
0043648
Compare
For now I changed this PR to only move the products to dedicated projects so that the pom-files can be removed. Fixing them will be done in a later PR. |
Remove the org.eclipse.equinox.p2.reconciler.dropins/Bootstrap.product, which is not used anywhere and seems only to be used to boot-strap the 'Reconciler' launch-configs. They are outdated and can be simpler created from the launch-config dialog. Remove now obsolete pom-files. They were only necessary because Tycho-pomless otherwise does not yet use packaging-type 'eclipse-plugin'. Remove p2.inf files for products. They add repositories that don't exist. And if a update-repo is desired later, it can be specified in the product-file. Remove launch-configs associated to products. If one wants to launch the product, it can be easily done from the Product-editor.
0043648
to
a6708d8
Compare
Additionally