Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Move all products to dedicated folder #114

Merged
merged 2 commits into from
Sep 11, 2022

Conversation

HannesWell
Copy link
Member

Additionally

  • Remove now obsolete pom-files. They were only necessary because Tycho-pomless otherwise does not use packaging-type 'eclipse-plugin'.
  • Remove p2.inf files for products, because they add repositories that don't exist. And if a update-repo is desired later it can be configured in the product.
  • Remove launch-configs associated to products. If one wants to launch the product, it can be easaly done from the Product-editor.

@HannesWell
Copy link
Member Author

The org.eclipse.equinox.p2.director.app.product has to be changed to be based on Plug-ins. Otherwise we always have issues with features in other repos that include Plug-ins from this repo.

@laeubi
Copy link
Member

laeubi commented Jul 20, 2022

@HannesWell building products can add considerably to build times, I thin we should use a profile to explicitly enable that.

@HannesWell
Copy link
Member Author

@HannesWell building products can add considerably to build times, I thin we should use a profile to explicitly enable that.

That's right. On other hand building them (at least occasionally) makes sure they continue to work.

Maybe it would be reasonable to only build them in I-builds?

@HannesWell HannesWell force-pushed the moveProducts branch 2 times, most recently from 7d2f103 to 3c74328 Compare July 24, 2022 13:08
@HannesWell HannesWell changed the title Move all products to dedicated folder and build them Move all products to dedicated folder Sep 11, 2022
@HannesWell
Copy link
Member Author

For now I changed this PR to only move the products to dedicated projects so that the pom-files can be removed. Fixing them will be done in a later PR.
However onces eclipse-tycho/tycho#1299 is available (i.e. we use Tycho-3.0 in .mvn/extensions.xml) removing the pom.xml should be possible even with product-files within a Plug-in project because the BundleMapping now takes precedence over the Repository-Mapping. Nevertheless I think it is usefull to move those products into dedicated folders because this allows to build them (if desired), as long as Tycho does not support building products included in plug-in projects.

Remove the org.eclipse.equinox.p2.reconciler.dropins/Bootstrap.product,
which is not used anywhere and seems only to be used to boot-strap the
'Reconciler' launch-configs. They are outdated and can be simpler
created from the launch-config dialog.

Remove now obsolete pom-files. They were only necessary because
Tycho-pomless otherwise does not yet use packaging-type
'eclipse-plugin'.

Remove p2.inf files for products. They add repositories that don't
exist. And if a update-repo is desired later, it can be specified
in the product-file.

Remove launch-configs associated to products. If one wants to launch
the product, it can be easily done from the Product-editor.
@HannesWell HannesWell merged commit 0c75aae into eclipse-equinox:master Sep 11, 2022
@HannesWell HannesWell deleted the moveProducts branch September 11, 2022 20:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants