Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

iox-#1906 Fix grub efi issue in ros ci action #1920

Conversation

dkroenke
Copy link
Member

@dkroenke dkroenke commented Feb 24, 2023

The package installation of grub-efi-amd64-signed in the GitHub Action from https://github.com/ros-tooling/setup-ros.
This causes an hard error for updating APT for ROS 2. Holding back the package from installation will solve this temporally.

The follow-up is addressed in ros-tooling/setup-ros#542 which may makes an update of the Action necessary.

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
  11. Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@dkroenke dkroenke added the bugfix Solves a bug label Feb 24, 2023
@dkroenke dkroenke self-assigned this Feb 24, 2023
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #1920 (9675e42) into master (7036430) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1920      +/-   ##
==========================================
+ Coverage   75.45%   75.47%   +0.01%     
==========================================
  Files         384      384              
  Lines       15202    15202              
  Branches     2149     2149              
==========================================
+ Hits        11471    11474       +3     
  Misses       3058     3058              
+ Partials      673      670       -3     
Flag Coverage Δ
unittests 75.13% <ø> (+0.01%) ⬆️
unittests_timing 15.49% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
iceoryx_posh/source/roudi/port_manager.cpp 84.76% <0.00%> (+0.35%) ⬆️
iceoryx_hoofs/source/concurrent/loffli.cpp 84.84% <0.00%> (+3.03%) ⬆️

elBoberido
elBoberido previously approved these changes Feb 24, 2023
@dkroenke dkroenke marked this pull request as draft February 24, 2023 13:25
@mossmaurice mossmaurice removed the request for review from MatthiasKillat February 24, 2023 13:32
mossmaurice
mossmaurice previously approved these changes Feb 24, 2023
@dkroenke dkroenke closed this Feb 24, 2023
@dkroenke dkroenke force-pushed the iox-1906-fix-grub-efi-issue-in-ros-ci-action branch from c7e3b95 to 0a29a24 Compare February 24, 2023 13:36
@dkroenke dkroenke reopened this Feb 24, 2023
@dkroenke dkroenke dismissed stale reviews from mossmaurice and elBoberido via 79cd098 February 24, 2023 16:31
@dkroenke dkroenke marked this pull request as ready for review February 24, 2023 16:31
@dkroenke dkroenke closed this Feb 24, 2023
@dkroenke dkroenke force-pushed the iox-1906-fix-grub-efi-issue-in-ros-ci-action branch from 79cd098 to 0487837 Compare February 24, 2023 16:32
…itHub CI for ROS 2

Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
@dkroenke dkroenke reopened this Feb 24, 2023
@dkroenke dkroenke closed this Feb 24, 2023
@dkroenke dkroenke changed the title iox-#1906 Hold back grub-efi-amd64-signed before setup-ros execution iox-#1906 Fix grub efi issue in ros ci action Feb 27, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bugfix Solves a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

integrationtest CI job failing
3 participants