Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

maintenance:GitHub actions, seat_service #61

Conversation

int0x27
Copy link
Contributor

@int0x27 int0x27 commented Mar 13, 2023

  • Add version as input to release workflow dispatch
  • Fixed SIGSEGV in seat_service when bind() failed, fixed spelling
  • Also fixed megalinter spellchecker suggestion
  • Fixed conan version in dev container
    • optimized apt install, added missing jq
    • fixed hvac service update-protobuf.sh and regenerated stubs
  • Upgraded to megalinter v6, fixed some issues, disabled megalinter errors (check lint logs for warnings)
  • Upgraded dependabot versions
  • Fixed code coverage action to skip posting comments on "foreign" pull requests (no write permissions)

- fixed megalinter issues
- disabled yamllint errors

Signed-off-by: Ivan Kirchev <Ivan.Kirchev@bosch.com>
- attempt to reduce yamllinter errors on githubactions

Signed-off-by: Ivan Kirchev <Ivan.Kirchev@bosch.com>
Signed-off-by: Ivan Kirchev <Ivan.Kirchev@bosch.com>
Signed-off-by: Ivan Kirchev <Ivan.Kirchev@bosch.com>
Signed-off-by: Ivan Kirchev <Ivan.Kirchev@bosch.com>
Signed-off-by: Ivan Kirchev <Ivan.Kirchev@bosch.com>
- optimized apt install, added missing jq
- fixed hvac service update-protobuf.sh and regenerated stubs
- disable megalinter errors for now

Signed-off-by: Ivan Kirchev <Ivan.Kirchev@bosch.com>
- Also fixed megalinter spellchecker suggestion
Signed-off-by: Ivan Kirchev <Ivan.Kirchev@bosch.com>
cobertura-action is not executed as it won't have write permission to comment

Signed-off-by: Ivan Kirchev <Ivan.Kirchev@bosch.com>
Copy link
Contributor

@SebastianSchildt SebastianSchildt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good improvement on CI.
Just reminds me HVAC service needs some love maybe, but one thing at a time...
🦑

@SebastianSchildt SebastianSchildt merged commit a3dc2f4 into eclipse-kuksa:main Mar 14, 2023
@erikbosch erikbosch deleted the feature/maintenance-github-actions branch February 27, 2024 11:52
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants