Support users to replace parser rules which are used only as type for cross-references by type declarations #1391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohannesMeierSE
force-pushed
the
validation-unused-rule-crossreference
branch
from
59cd7b0 to
136a1f9
Compare
JohannesMeierSE
force-pushed
the
validation-unused-rule-crossreference
branch
from
136a1f9 to
b05bcac
Compare
|
FYI: I just resolved conflicts with |
… parsing, but for cross-references eclipse-langium#1309
…th explicitly inferred type - including a WIP fix for InferredTypes in the grammar
…lity and comments
JohannesMeierSE
force-pushed
the
validation-unused-rule-crossreference
branch
from
b05bcac to
359e54e
Compare
|
FYI: I just resolved conflicts with While this validation looks like a small one, I found this issue in several projects in practice 🙂 |
msujew
reviewed
Feb 17, 2025
| @@ -180,6 +183,67 @@ export class LangiumGrammarCodeActionProvider implements CodeActionProvider { | |||
| return undefined; | |||
| } | |||
|
|
|||
| private isRuleReplaceable(rule: ast.ParserRule): boolean { | |||
| /** at the moment, only "pure" parser rules are supported: | |||
There was a problem hiding this comment.
Question: Do you plan to support more parser rules? I.e. those that should be transformed into interfaces?
There was a problem hiding this comment.
At the moment, I don't plan to support more parser rules. In practice, I saw only the handled "simple" cases. I am not sure whether it is worth the effort to support more cases. Do you have some examples we should handle?
|
Thanks @msujew for your review! I just pushed the corresponding fixes. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes the following things and closes #1309:
testQuickFixinpackages/langium/src/test/langium-test.ts). This function is tested by applying it to the mentioned new quick-fix for the Langium grammar.