Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

use node 18 engines! #1813

Merged
merged 1 commit into from
Feb 17, 2025
Merged

use node 18 engines! #1813

merged 1 commit into from
Feb 17, 2025

Conversation

cdietrich
Copy link
Contributor

No description provided.

@cdietrich cdietrich requested a review from msujew February 17, 2025 07:57
@cdietrich
use node 18 engines!
041a0ce 
Signed-off-by: Christian Dietrich <christian.dietrich.opensource@gmail.com>
msujew
msujew approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, Langium should be compatible with node 16, even though we already use @types/node: 18. However, I don't think node 16 is a relevant use case anymore, and we should drop it.

@msujew msujew merged commit 87cbe24 into main Feb 17, 2025
5 checks passed
@msujew msujew deleted the cd-more-node-18 branch February 17, 2025 13:33
@spoenemann spoenemann added this to the v3.4.0 milestone Feb 21, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@msujew msujew msujew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cdietrich @msujew @spoenemann