Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Created Authorizer for Bootstrap server #1362

Closed

Conversation

Warmek
Copy link
Contributor

@Warmek Warmek commented Nov 28, 2022

This implements authorizer interface for Bootstrap server in similar way to how it is done in Leshan Server.

@sbernard31
Copy link
Contributor

@Warmek, it seems there is an issue with your eca.

Please do not create a new PR, we will try to resolve this using this PR.

First I will check your eca by myself.

@sbernard31
Copy link
Contributor

I check it and it seems you didn't sign any ECA with email adress you used to create your commit.

Look at this : https://github.com/eclipse/leshan/wiki/How-to-contribute#legal-stuff- for more details.

@sbernard31
Copy link
Contributor

sbernard31 commented Nov 28, 2022

Once it's done, let me know.

@Warmek
Copy link
Contributor Author

Warmek commented Nov 28, 2022

@sbernard31 I've signed the agreement you've sent me. Sorry it took so long

@sbernard31
Copy link
Contributor

Sorry it took so long

No problem 😉

I check your ECA and it seems valid now. ✔️.

I try to relaunch validating tools (eclipsefdn/eca) and still get a ❌...
Possibly a bug in this validating tools ? (managed by eclipse foundation)

Just by curiosity, do you add/link your github account to your eclipse account ?
At https://accounts.eclipse.org/ in MyProfile/ Edit Profile/ Personal Information/Social Media Links/GitHub Username ?

@Warmek
Copy link
Contributor Author

Warmek commented Nov 28, 2022

Yes, my GitHub username in eclipse profile is correct

@sbernard31
Copy link
Contributor

Yes, my GitHub username in eclipse profile is correct

Ok I rerun the valdation tools and this time we get a ✔️

Let's see now if your PR pass "Check Pull Request" validation 🙂

@sbernard31
Copy link
Contributor

I think it's OK now. 👍

I will just rebase this on master and squash all commit in one and probably edit commit name to add a reference to GH-1359.

@sbernard31
Copy link
Contributor

Integrated in master (commit 05dbddb)

@Warmek thx for contribution 🙏 !

@sbernard31 sbernard31 closed this Dec 1, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants