Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

perf: use Set instead of List to track subClasses in GarbageCleaner #63

Merged
merged 1 commit into from
Aug 12, 2024
Merged

perf: use Set instead of List to track subClasses in GarbageCleaner #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions plugins/org.eclipse.mat.parser/src/org/eclipse/mat/parser/model/ClassImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,10 @@
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
import java.util.LinkedHashSet;
import java.util.LinkedList;
import java.util.List;
import java.util.Set;
import java.util.concurrent.atomic.AtomicIntegerFieldUpdater;
import java.util.concurrent.atomic.AtomicLongFieldUpdater;

Expand Down Expand Up @@ -67,7 +69,7 @@ public class ClassImpl extends AbstractObjectImpl implements IClass, Comparable<
protected volatile long totalSize;
protected boolean isArrayType;

private List<IClass> subClasses;
private Set<IClass> subClasses;

private Serializable cacheEntry;

Expand Down Expand Up @@ -392,14 +394,14 @@ void removeInstanceBulk(int instanceCount, long heapSize)
@SuppressWarnings("unchecked")
public List<IClass> getSubclasses()
{
return subClasses != null ? subClasses : Collections.EMPTY_LIST;
return (subClasses == null) ? Collections.emptyList() : new ArrayList<>(subClasses);
}

@Override
public List<IClass> getAllSubclasses()
{
if (subClasses == null || subClasses.isEmpty())
return new ArrayList<IClass>();
return Collections.emptyList();

List<IClass> answer = new ArrayList<IClass>(subClasses.size() * 2);
answer.addAll(this.subClasses);
Expand Down Expand Up @@ -453,7 +455,7 @@ public int getClassLoaderId()
public void addSubClass(ClassImpl clazz)
{
if (subClasses == null)
subClasses = new ArrayList<IClass>();
subClasses = new LinkedHashSet<IClass>();
subClasses.add(clazz);
}

Expand Down