Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix #89 - read and write List instead of Set during ClassImpl serialization #91

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

jasonk000
Copy link
Contributor

this was a backwards-incompatible change previously introduced

@kgibm
Copy link
Member

kgibm commented Jan 7, 2025

[ERROR] 	private void writeObject(ObjectOutputStream out) throws IOException {
[ERROR] 	                         ^^^^^^^^^^^^^^^^^^
[ERROR] ObjectOutputStream cannot be resolved to a type

[ERROR] 	private void readObject(ObjectInputStream in) throws IOException, ClassNotFoundException {
[ERROR] 	                        ^^^^^^^^^^^^^^^^^
[ERROR] ObjectInputStream cannot be resolved to a type

@jasonk000 jasonk000 force-pushed the backwards-compatibility-classimpl-ser-deser branch from 59cd765 to 5e332ab Compare January 7, 2025 19:00
…zation

this was a backwards-incompatible change previously introduced
@jasonk000 jasonk000 force-pushed the backwards-compatibility-classimpl-ser-deser branch from 5e332ab to d2a4ce6 Compare January 7, 2025 19:20
Copy link
Member

@kgibm kgibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the latest patch and it seems to work. I first cleaned the index files, then loaded with MAT 1.15 and then loaded with a build with this patch and it worked. Previously, the same process with vanilla MAT 1.16 failed.

@jasonk000
Copy link
Contributor Author

jasonk000 commented Jan 7, 2025

Great, I'm doing a bit more testing on my side and then will finalise the PR. Thank you for the quick feedback!

@jasonk000 jasonk000 marked this pull request as ready for review January 7, 2025 19:53
@jasonk000
Copy link
Contributor Author

I tested

  • MAT 1.15 index, MAT 1.16 can open ✅
  • MAT 1.16 index, MAT 1.15 can open ✅
  • MAT 1.16 index, MAT 1.16 can open ✅

@jasonk000 jasonk000 merged commit ac829d1 into master Jan 7, 2025
1 check passed
@jasonk000 jasonk000 deleted the backwards-compatibility-classimpl-ser-deser branch January 7, 2025 20:06
@krumts
Copy link
Contributor

krumts commented Jan 8, 2025

Shall I prepare a new bugfix release (1.16.1) for this one?
I guess the ones who downloaded 1.16.0 already will have a similar issue when upgrading to 1.16.1... the new version was out for less than a month, this should be a smaller impact I guess.

@kgibm
Copy link
Member

kgibm commented Jan 8, 2025

Given that we don't often create new releases and my guess is this will impact a non-trivial number of users, so I think that would be worth it, thanks Krum!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants