Throw IllegalAccessError (IAE): Lookup.findVirtual #13740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Throw IAE for non-public virtual methods if invoked by MethodHandles created using Lookup.findVirtual. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
This was referenced Oct 19, 2021
For KIND_INTERFACE, OpenJ9 MHs always get the method from the vTable. Private methods do not appear in the vTable. So, the check for J9AccPrivate is not needed. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
The interface dispatch implemented by InterfaceHandle is supposed to throw IllegalAccessError (IAE) when the dispatched callee is not public, just like the dispatch performed by invokeinterface.
keithc-ca
approved these changes
Oct 19, 2021
|
This has been tested internally. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw IAE for non-public virtual methods if invoked by MethodHandles created
using Lookup.findVirtual.
For KIND_INTERFACE, OpenJ9 MHs always get the method from the vTable. Private
methods do not appear in the vTable. So, the check for J9AccPrivate is not
needed.